-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDP-1001] refactor migration commands to keep a consistent naming approach, in preparation for the TSS migrations (pt 1/2) #123
Conversation
stellar-disbursement-platform-backend-preview is available here: |
stellar-disbursement-platform-backend-preview is available here: |
stellar-disbursement-platform-backend-preview is available here: |
stellar-disbursement-platform-backend-preview is available here: |
stellar-disbursement-platform-backend-preview is available here: |
3aca6c5
to
2f56097
Compare
stellar-disbursement-platform-backend-preview is available here: |
stellar-disbursement-platform-backend-preview is available here: |
stellar-disbursement-platform-backend-preview is available here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stellar-disbursement-platform-backend-preview is available here: |
14cf079
to
13fed1e
Compare
stellar-disbursement-platform-backend-preview is available here: |
13fed1e
to
4c6696c
Compare
stellar-disbursement-platform-backend-preview is available here: |
stellar-disbursement-platform-backend-preview is available here: |
What
The main change here was to update the migration commands so all of them have a consistent hierarchy. Here is what they look like right now:
db sdp migrate up | down
: for sdp per-tenant migrations. Notice it had a different (global) hierarchy despite being a per-tenant commanddb migrate up | down
db auth migrate up | down
: for auth per-tenant migrationsdb admin migrate up | down
: for admin migrations that are relevant to registering and organizing the tenants. It was for a global thing, yet it looked less global than the first command. Also, despite being calleddb tenant migrate up | down
tenant
, it had a global scope rather than per-tenantAdditional changes:
Why
Checklist
PR Structure
Thoroughness
Configs and Secrets
values.yaml
file.pr-preview
,dev
,demo
,prd
).values.yaml
file.pr-preview secrets
,dev secrets
,demo secrets
,prd secrets
).Release
develop
ormain
after it's ready for production!Deployment